#19461 Rework Shout Preferences by belaroesener · Pull Request #19464 · pharo-project/pharo

belaroesener · 2026-03-25T10:30:47Z

I reorganized the Shout Preferences around the predefined styles already available, adding two special styles Custom and Default.
Default represents the style for the currently selected UI Theme and will change if the UI Theme changes.
Custom represents the style editable via the SettingBrowser and can be initialized by copying it from any of the other styles.

I fixed the problems described in #19461:

With the new system, when loading a UI Theme, the current style is only changed to the Theme default, if the currently selected style is Default
I send #themeChanged to the world whenever any of the style elements is changed in the SettingBrowser. This works but I would be happy for any suggestions to make it work better, as this solution seems somewhat inefficient.
I replaced SHStyleElement with two new classes, that manage the state in a different way, and do not exhibit the same problems.
The emphasis bold italic now works

- Reorganize the syntax highlighting settings around the predefined styles - Create two new predefined styles `Custom` and `Default` with special behaviour - Modify logic for switching the UITheme so that changing it only switches the style if the current style is `Default` - Fix emphasis `bold italic` - Make open code editors reflect changes to the `Custom` style directly - Reorganize the inner workings of `SHPreferences` - Replace `SHStyleElement` with `SHCustomStyle` and `SHCustomStyleElement`

- Remove unused methods from `SHPreferences class` - Remove obsolete comments and todos - Add descriptions for settings - Fix formatting

jecisc · 2026-03-25T14:46:06Z

@demarey and @estebanlm are currently working on the SettingBrowser.

Maybe they can be interested to review this PR

estebanlm · 2026-03-25T14:48:16Z

is this working in the context of the new settings browser ?

Ducasse · 2026-03-25T19:58:35Z

+SHCustomStyle class >> color: aColor forGroup: aGroupName [
+
+	(groups at: aGroupName) at: #color put: aColor.
+	SHPreferences cutomStyleChanged


It feels like a typo

Ducasse · 2026-03-25T20:01:00Z

Hi belaroesener

If you have some cycles for another PR after we integrate this one.
I would love to see all the symbols used in all Shout turned into strings because these symbols are unnecessary and polutes de symbol space.
This is on my todo but it is kind of infinite in this moment.

Tx

belaroesener · 2026-03-26T09:41:47Z

is this working in the context of the new settings browser ?

This PR addresses the Issues I had with the old settings browser. I had not followed the development of the new setting browser, but now I am realizing that it is the default Browser in Pharo14? (I always use CMD-, to open the settings browser, but this still opens the old browser).

The style elements use special widgets, from my understanding the logic used by the new browser is a bit different for this. I'll look into it

belaroesener · 2026-03-26T09:46:00Z

Hi belaroesener

If you have some cycles for another PR after we integrate this one. I would love to see all the symbols used in all Shout turned into strings because these symbols are unnecessary and polutes de symbol space. This is on my todo but it is kind of infinite in this moment.

Tx

Sure, could you elaborate a bit on what symbols you mean?

jecisc · 2026-03-26T13:07:29Z

I think he is refering to the methods with the pragma #styleTable:

For example:

^ #(
			(default 								('657A81' muchDarker))
			...
)

This will create symbols. He would like it to become

^ #(
			('default' 								('657A81' muchDarker))
			...
)

This is what I understood. Maybe Steph can confirm

Ducasse · 2026-04-03T19:42:19Z

Yes I refered to this list of symbols.

Ducasse · 2026-04-07T19:04:37Z

Hello did you see my comment? cutom has a typo.

belaroesener · 2026-04-10T13:09:30Z

@Ducasse Yes, it's a typo. Thanks, I'll fix it.

Ducasse · 2026-04-11T07:09:42Z

Thanks. Can you check the conflict?

Ducasse · 2026-05-05T18:10:59Z

Tx I will integrate it now.
My remark about symbol use is still valid.
We should minimize the use of Symbol.

Ducasse · 2026-05-05T18:12:01Z

I do not get why the build is not working so I trigger a rebuild and we will have look at the build.

Rename `SHCustomStyleElement` to `SHStyleElement` (the class it replaced) to fix dependency of Pharo-NewTools.

belaroesener · 2026-05-08T11:51:24Z

We should minimize the use of Symbol.

I'm looking into it now.

Ducasse · 2026-05-08T14:47:00Z

Excellent. Basically I was analyze the use of symbols and it seems that it does not use an identity based structure, so it means that using strings for keys is just enough.

Ducasse · 2026-05-08T14:47:43Z

The changes are looking ok to me. Let me know when I can integrate.

Ducasse · 2026-05-09T08:29:46Z

@belaroesener
did you see also #19654

…onary` internally. (This will make the transition from symbols to strings easier)

…re possible)

belaroesener · 2026-05-12T12:27:04Z

@belaroesener did you see also #19654

@Ducasse I looked at it, but I can not reproduce it. It does not sound like it has anything to do with Shout.

My code should be ready to integrate now

Ducasse · 2026-05-12T13:43:52Z

Thanks a lot!

Ducasse · 2026-05-19T19:04:08Z

I;m sorry that we do not integrate it before but we got many regression.
I'm relaucnhing the build to get a fresh view and I would like to push this into pharo.

Ducasse · 2026-06-03T14:03:38Z

I see that

[Shout.Tests.SHStyleElementTest.testPrintOn](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-19464/10/testReport/junit/MacOSX64.Tests-osx-64.Shout.Tests/SHStyleElementTest/osx_64___Tests_osx_64___testPrintOn/)
[Shout.Tests.SHStyleElementTest.testStyleForTable](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-19464/10/testReport/junit/MacOSX64.Tests-osx-64.Shout.Tests/SHStyleElementTest/osx_64___Tests_osx_64___testStyleForTable/)

are broken

belaroesener · 2026-06-17T13:01:58Z

Sorry, that was an obvious oversight on my part. Looking at the tests, they are not relevant to the new implementation. I'll just delete them then?

Ducasse · 2026-06-17T19:15:15Z

I think that two tests are failing that are related to the Pr

testStoreAndLoadAllSystemSettings
Windows64.Tests-windows-64.System.Settings.Tests.SystemSettingsPersistenceTest
7 0.29 sec
Error Details
Got Dictionary instead of SHStyleElement.
Stack Trace

TestFailure
Got Dictionary instead of SHStyleElement.
SystemSettingsPersistenceTest(TestAsserter)>>assert:description:resumable:
SystemSettingsPersistenceTest(TestAsserter)>>assert:description:
SystemSettingsPersistenceTest(TestAsserter)>>assert:equals:
[ ] in SystemSettingsPersistenceTest>>testStoreAndLoadAllSystemSettings
Array(SequenceableCollection)>>do:
SystemSettingsPersistenceTest>>testStoreAndLoadAllSystemSettings
SystemSettingsPersistenceTest(TestCase)>>performTest

and

ReleaseTests.NoUnusedVariablesLeftTest
](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-19464/12/testReport/Windows64.Tests-windows-64.ReleaseTests/NoUnusedVariablesLeftTest/windows_64___Tests_windows_64___testNoUnusedInstanceVariablesLeft/)
7 0.46 sec
Error Details
the following classes have unused instance variables and should be cleaned: an OrderedCollection(SHPreferences class)
Stack Trace

TestFailure
the following classes have unused instance variables and should be cleaned: an OrderedCollection(SHPreferences class)
NoUnusedVariablesLeftTest(TestAsserter)>>assert:description:resumable:
NoUnusedVariablesLeftTest(TestAsserter)>>assert:description:
NoUnusedVariablesLeftTest>>testNoUnusedInstanceVariablesLeft
NoUnusedVariablesLeftTest(TestCase)>>performTest

windows-64 / Tests-windows-64 / testNoUnusedInstanceVariablesLeft - Test pending pull request and branch Pipeline/PR-19464 #12 - Jenkins

belaroesener added 4 commits March 25, 2026 11:22

Clean up

bca4f74

- Remove unused methods from `SHPreferences class` - Remove obsolete comments and todos - Add descriptions for settings - Fix formatting

Update SettingBrowser when copying the Custom style from the current one

f3bd8de

Fix emphasis 'bold italic'

6a1969a

Ducasse reviewed Mar 25, 2026

View reviewed changes

Correct typo

e4ea4e1

belaroesener added 2 commits May 5, 2026 12:14

Merge branch 'Pharo14' into improvement/rework-shout-preferences

2ae1ced

Remove unused methods

f745e20

Ducasse closed this May 5, 2026

Ducasse reopened this May 5, 2026

belaroesener added 2 commits May 8, 2026 11:40

Fix dependency error

e7cff52

Rename `SHCustomStyleElement` to `SHStyleElement` (the class it replaced) to fix dependency of Pharo-NewTools.

Remove superfluouse symbols from new code.

e62c010

belaroesener added 2 commits May 12, 2026 13:18

Change SHRBTextStyler to use Dictionary instead of `IdentityDicti…

4d1bbca

…onary` internally. (This will make the transition from symbols to strings easier)

Change predefined style tables to use strings instead of symbols (whe…

86575dd

…re possible)

belaroesener added 3 commits May 12, 2026 13:58

Change all style names in Shout from symbols into strings

f754c49

Remove last the last symbols from Shout code

3b6c417

Merge branch 'Pharo14' into improvement/rework-shout-preferences

0bfb3af

Ducasse closed this May 19, 2026

Ducasse reopened this May 19, 2026

belaroesener added 5 commits June 17, 2026 15:51

Add missing accessor and printOn:

d534937

Remove outdated tests

398355b

Add new tests

9e67dbf

Merge 0bfb3af

0c55a7d

Merge branch 'Pharo14' into improvement/rework-shout-preferences

2c32403

Uh oh!

Uh oh!

Conversation

belaroesener commented Mar 25, 2026

Uh oh!

jecisc commented Mar 25, 2026

Uh oh!

estebanlm commented Mar 25, 2026

Uh oh!

Ducasse Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Ducasse commented Mar 25, 2026

Uh oh!

belaroesener commented Mar 26, 2026

Uh oh!

belaroesener commented Mar 26, 2026

Uh oh!

jecisc commented Mar 26, 2026

Uh oh!

Ducasse commented Apr 3, 2026

Uh oh!

Ducasse commented Apr 7, 2026

Uh oh!

belaroesener commented Apr 10, 2026

Uh oh!

Ducasse commented Apr 11, 2026

Uh oh!

Ducasse commented May 5, 2026

Uh oh!

Ducasse commented May 5, 2026

Uh oh!

belaroesener commented May 8, 2026

Uh oh!

Ducasse commented May 8, 2026

Uh oh!

Ducasse commented May 8, 2026

Uh oh!

Ducasse commented May 9, 2026

Uh oh!

belaroesener commented May 12, 2026

Uh oh!

Ducasse commented May 12, 2026

Uh oh!

Ducasse commented May 19, 2026

Uh oh!

Ducasse commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

belaroesener commented Jun 17, 2026

Uh oh!

Ducasse commented Jun 17, 2026 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ducasse commented Jun 3, 2026 •

edited

Loading

Ducasse commented Jun 17, 2026 •

edited by unfurl-links Bot

Loading